Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we move env folder of uwsgi stack out of /opt/app? #334

Open
ocdtrekkie opened this issue Sep 6, 2022 · 3 comments
Open

Should we move env folder of uwsgi stack out of /opt/app? #334

ocdtrekkie opened this issue Sep 6, 2022 · 3 comments

Comments

@ocdtrekkie
Copy link
Collaborator

So, I've been working on updating the uwsgi stack, and on Windows, difficulty using symlinks on the shared folder caused me some issues using the virtualenv command in build.sh. I was able to get it to work by adding the --copies option, so instead of generating symlinks, it had duplicate copies of some files, python, python3, python3.9 all being the same file, for example instead of symlinked together. If someone's app calls multiple synonymous files, if we use --copies, we'd bloat the SPK, so I chose not to do that in the PR.

However, I am not sure there's a good case/reason for the env folder to be inside /opt/app in the first place: If we moved it elsewhere, this wouldn't be an issue for Windows vagrant-spk users. Is there an appropriate alternative location to put this?

@zenhack
Copy link
Collaborator

zenhack commented Sep 6, 2022 via email

@ocdtrekkie
Copy link
Collaborator Author

I am good with that, and another subfolder of /opt/ was my first thought, but I didn't know if there was somewhere in particular that would feel conventional on a Linux system. I will go ahead and test that before I merge all of this together, and likely tag a vagrant-spk 1.2 release since this is all a pretty significant change.

@ocdtrekkie
Copy link
Collaborator Author

abaca56 fixes this. Note that making directories in /opt/app hits a permission error, so I had to add a line to clobber that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants