Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-047 Use stored procedure to retrieve destination plate information #381

Open
1 task
pjvv opened this issue Jun 29, 2021 · 4 comments
Open
1 task

DPL-047 Use stored procedure to retrieve destination plate information #381

pjvv opened this issue Jun 29, 2021 · 4 comments
Labels
Beckman integration Beckman integration Enhancement New feature or request On Hold

Comments

@pjvv
Copy link
Contributor

pjvv commented Jun 29, 2021

User story
As a development team we would like to change how we query the DART database to retrieve the destination plate information. We are using currently using a view but the view is not operating efficiently and can lead to blocking issues. A stored procedure should operate most efficiently and provide the same, required output.

Who are the primary contacts for this story
@pjvv
@andrewsparkes

Acceptance criteria
To be considered successful the solution must allow:

  • call a stored procedure instead of the view

Dependencies
This story is blocked by the following dependencies:

  • #<issue_no.>
  • sanger/#<issue_no.>

References
This story has a non-blocking relationship with:

  • #<issue_no.>
  • sanger/#<issue_no.>

Additional context
Yann will be assisting from the DBA team to convert the view to a stored procedure and help us optimise the interactions between LIMS and SQL Server.

@pjvv pjvv added the Enhancement New feature or request label Jun 29, 2021
@rl15 rl15 changed the title DPL-nnn Use stored procedure to retrieve destination plate information DPL-047 Use stored procedure to retrieve destination plate information Jun 30, 2021
@andrewsparkes andrewsparkes added the Beckman integration Beckman integration label Jul 19, 2021
@harrietc52
Copy link
Contributor

harrietc52 commented Jul 27, 2021

Update: Not sure this story is any longer required

@TWJW-SANGER
Copy link

TWJW-SANGER commented Jul 27, 2021

Eduardo and I have just had a meeting with Yann L. who re-configured the queries underlying the two views in the production DART database as a hot fix:
view_run_history - used by Sara Stott’s team through Tableau in 2 reports
view_heron_hitpicks – used by LIMS

With these changes the performance has increased from more than 3 mins from Tableau to less than 15 seconds, he has also taken steps to prevent the performance degrading with more data.

We do need to be careful though - so next steps will be

  • Discuss with Sara S on how to gradually test use of Tableau reports during the day
  • Monitoring the time the queries / reports take to run - to catch any further problems earlier

Hopefully a stored procedure won't be needed if performance remains acceptable to avoid more production hot-fixes.

@TWJW-SANGER
Copy link

TWJW-SANGER commented Aug 3, 2021

Sara is currently testing the changes Yann made to the DART database - expecting feedback week starting 9th August

This issue should be considered On Hold

Longer term she is looking to get a combined report for Biosero & Beckman robots - this is captured in DPL-095.

@TWJW-SANGER
Copy link

TWJW-SANGER commented Aug 9, 2021

Sara has tested the Tableau report and unfortunately it is still taking minutes to render, so the test has failed.
This is odd as the underlying view is much faster following Yann's improvements.

The next step is to work out with Scott what's required to do DPL-095 and then decide whether this story should go ahead as a temporary fix, or it's just better to design out the problem and go with DPL-095.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beckman integration Beckman integration Enhancement New feature or request On Hold
Projects
None yet
Development

No branches or pull requests

4 participants