Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-470-1: malformed root_sample_ids that were picked, but are not duplicated in MLWH #538

Open
4 tasks
Jonnie-Bevan opened this issue Mar 17, 2022 · 0 comments
Labels
Data integrity data fix Enhancement New feature or request GSU Delivers work for the GSU unit Heron RVI RVI Project

Comments

@Jonnie-Bevan
Copy link

Jonnie-Bevan commented Mar 17, 2022

User Story
Part of the wider DPL-470 issue which spawned in turn from DPL-048. Related are DPL-0483-2, DPL-0483-3 and DPL-0483-5

This story concerns the 1,128 malformed root_sample_ids in the MLWH lighthouse_sample table which were picked at some point and are therefore in SS, the MLWH sample table and Event Warehouse as well as lighthouse_sample (+ MongoDB). These came from the MK lighthouse lab in 2021 and have an extra substring (something like '_RNA123456789') concatenated on the end of the correct ID.

Fix
These IDs are not duplicated in MLWH or elsewhere (as far as I know currently), so the fixed ID can simply update the ID in each of the 5 places it needs updating. The fix simply involves removing any string from after the underscore.

Who are the primary contacts for this story
Jonnie B
Alan K

Acceptance criteria

  • data are fixed in MLWH lighthouse_sample table
  • data are fixed in MongoDB sample table
  • data are fixed in SequenceScape samples table (root_sample_id is called description here). This should proliferate to the MLWH sample table, but this needs to be checked to be sure
  • data are fixed in Event Warehouse
@Jonnie-Bevan Jonnie-Bevan added Enhancement New feature or request Data integrity data fix labels Mar 17, 2022
@Jonnie-Bevan Jonnie-Bevan self-assigned this Mar 17, 2022
@sdjmchattie sdjmchattie changed the title DPL-048-4: malformed root_sample_ids that were picked, but are not duplicated in MLWH DPL-470-1: malformed root_sample_ids that were picked, but are not duplicated in MLWH Aug 24, 2022
@andrewsparkes andrewsparkes added the RVI RVI Project label Sep 7, 2022
@TWJW-SANGER TWJW-SANGER added the GSU Delivers work for the GSU unit label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data integrity data fix Enhancement New feature or request GSU Delivers work for the GSU unit Heron RVI RVI Project
Projects
None yet
Development

No branches or pull requests

4 participants