Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-204 - GBS pipeline - enhancement - prevent Perform PCR button showing until state is 'started' #1795

Open
3 tasks
andrewsparkes opened this issue Jul 18, 2024 · 1 comment
Labels
GBS Need to Verify Research Research only Value: 2 Value to the insitute is low

Comments

@andrewsparkes
Copy link
Member

andrewsparkes commented Jul 18, 2024

User story
As Scott T I would like the GBS pipeline to prevent the 'Perform PCR' button on the PCR2 plate which changes the plate state to 'passed' from appearing until after the user has done the 'bravo GBS PCR1 to GBS PCR2' bed verification which changes the plate state to 'started'. At the moment the 'Perform PCR' button is visible earlier and can be pressed to bypass the need to use the robot.

Who are the primary contacts for this story
Scott T

Who is the nominated tester for UAT
Scott T

Acceptance criteria
To be considered successful the solution must allow:

  • after adding tags on creation of the PCR2 plate, only the 'bravo GBS PCR1 to GBS PCR2' bed verification button should be visible, not the 'Perform PCR' button
  • once the robot step is completed and plate state is 'started', the 'Perform PCR' button should be visible
  • the 'Perform PCR' button should change the plate state to 'passed', and the 'Add a GBS PCR2 Pool Stock Tube' button should be visible

Dependencies
None

References
None

Additional context
Noticed whilst testing the ANOSPP pipeline that feeds into GBS.
Not sure how possible this is. The 'Perform PCR' button is the equivalent of the 'Manual Transfer' button that is there in case the robot is unavailable. See app/models/presenters/minimal_pcr_plate_presenter.rb. Also see the integration suite spec/limber/gbs_pipeline_spec.rb.

@psd-issuer psd-issuer bot changed the title GBS pipeline - enhancement - prevent Perform PCR button showing until state is 'started' Y24-204 - GBS pipeline - enhancement - prevent Perform PCR button showing until state is 'started' Jul 18, 2024
@SujitDey2022 SujitDey2022 added GBS Value: 2 Value to the insitute is low Research Research only labels Jul 24, 2024
@SujitDey2022
Copy link

Team Discussion 24 July 2024:

  1. Need to confirm functionality of 'Perform PCR' button v/s Manual Transfer button.

config/locales/en.yml
pcr:
transitions:
passed: 'Perform PCR'

  1. Need to review the scope and user interaction benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GBS Need to Verify Research Research only Value: 2 Value to the insitute is low
Projects
None yet
Development

No branches or pull requests

2 participants