Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-299 - Addition of anonymous ids for public data sharing - sample manifest #1895

Closed
2 tasks
KatyTaylor opened this issue Sep 5, 2024 · 4 comments
Closed
2 tasks
Labels
Enhancement New feature or request RVI RVI project Size: M Medium - medium effort & risk

Comments

@KatyTaylor
Copy link
Contributor

KatyTaylor commented Sep 5, 2024

User story
As a member of GSU, I would like RVI samples imported via manifest (extracted onsite site) to have an anonymous id added to them, so that when they are shared in public databases, the id does not give any unnecessary information.

Who are the primary contacts for this story
Anna G, Adrianne L

Who is the nominated tester for UAT
Anna G, Ya-Lin H

Acceptance criteria
To be considered successful the solution must allow:

  • Samples imported via manifest for RVI study "RVI Program - Bait Capture" have an id created and inserted into the public name field
  • Id is created using Baracoda (RVI prefix)

References
This story has a non-blocking relationship with:

Additional context
Original request from Anna: "GSU would like to apply additional level of security in relation to sample IDs. This will need to be applied to future and all retrospective samples within RVI." (was split into 3 stories).

N.B. Is it worth checking before doing this story if the Sanger Sample Id would be sufficient? Is this used for existing samples in other studies? We discussed using the accession number but think this is not appropriate because it is specific to EBI and this will potentially be released to other databases as well.

@psd-issuer psd-issuer bot changed the title Addition of anonymous ids for public data sharing - sample manifest Y24-299 - Addition of anonymous ids for public data sharing - sample manifest Sep 5, 2024
@KatyTaylor KatyTaylor added Enhancement New feature or request RVI RVI project labels Sep 5, 2024
@KatyTaylor KatyTaylor added the On Hold On hold label Sep 5, 2024
@TWJW-SANGER
Copy link

I checked with Adrianne, she is happy to use an anonymous ID starting with "RVI":

I know we discussed that the WSI prefix would be used for the Anon ID could it be the RVI one instead. It’s still anon enough not to distinguish location.

@TWJW-SANGER TWJW-SANGER removed the On Hold On hold label Oct 17, 2024
@SujitDey2022 SujitDey2022 added the Size: M Medium - medium effort & risk label Nov 13, 2024
@SujitDey2022
Copy link

Team Discussion 13Nov2024:

Assumptions:

  1. Use of Public Name field in Sequencescape (and MLWH)
  2. May need to communicate with Release Team about this new field

@KatyTaylor
Copy link
Contributor Author

@TWJW-SANGER should this be closed for the same reason as #1851 ?

@TWJW-SANGER
Copy link

Yes. Good spot, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request RVI RVI project Size: M Medium - medium effort & risk
Projects
None yet
Development

No branches or pull requests

3 participants