Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-375 - File downloads improvements for MVP #1983

Open
3 tasks
KatyTaylor opened this issue Oct 10, 2024 · 0 comments
Open
3 tasks

Y24-375 - File downloads improvements for MVP #1983

KatyTaylor opened this issue Oct 10, 2024 · 0 comments
Labels
scRNA - cDNA prep scRNA Size: S Small - low effort & risk

Comments

@KatyTaylor
Copy link
Contributor

KatyTaylor commented Oct 10, 2024

User story
Tweaks to get these file downloads ready for the MVP version.

Who are the primary contacts for this story
Abby, Katy

Who is the nominated tester for UAT
Abby

Acceptance criteria
To be considered successful the solution must allow:

  • Refactor storage of common constants in the following 3 files so that they are not duplicated: hamilton_lrc_pbmc_defrost_pbs_to_lrc_pbmc_pools, hamilton_lrc_pbmc_defrost_pbs_to_cellaca_count, hamilton_gem_x_5p_chip_loading
  • Why are there two constants, required_number_of_cells and default_required_number_of_cells in the scrna_core_dna_prep.yml config? Are they the same thing?
  • For the chip loading file, hamilton_gem_x_5p_chip_loading, the value for the number of cells on the chip well (90,000) is not hardcoded, but is drawn from the request metadata (value has to be saved when pooling is done).

Dependencies

  • Have to decide how the value for the number of cells on the chip well will be stored. It will be saved in another story (yet to be created), to do with the pooling algorithm. It may not be the same as the value that is originally requested in the submission.

References
Following on from:

@KatyTaylor KatyTaylor added scRNA scRNA - cDNA prep Size: S Small - low effort & risk labels Oct 10, 2024
@psd-issuer psd-issuer bot changed the title File downloads improvements for MVP Y24-375 - File downloads improvements for MVP Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scRNA - cDNA prep scRNA Size: S Small - low effort & risk
Projects
None yet
Development

No branches or pull requests

1 participant