Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-nnn Remove print_list from global scope #185

Open
JamesGlover opened this issue Apr 14, 2022 · 0 comments
Open

DPL-nnn Remove print_list from global scope #185

JamesGlover opened this issue Apr 14, 2022 · 0 comments

Comments

@JamesGlover
Copy link

Describe the Housekeeping

https://github.com/sanger/samples_extraction/blob/3831e306b18c48d6074846669895e81d215eb99a/app/models/printables/print_asset.rb#L1-L16

This method is defined on Object. I think we can just remove it (couldn't find any calls to it), but if not it should be moved to somethign appropriate.

Blocking issues
Describe any other issues or tickets that may be blocking this change.

Additional context
Add any other context about the problem here.

JamesGlover pushed a commit that referenced this issue Apr 29, 2022
Fixes DPL-nnn Remove print_list from global scope #185

This method is defined on Object and so
is available globally. It appears to
be unused.
JamesGlover pushed a commit that referenced this issue May 3, 2022
Fixes DPL-nnn Remove print_list from global scope #185

This method is defined on Object and so
is available globally. It appears to
be unused.
JamesGlover pushed a commit that referenced this issue May 13, 2022
Fixes DPL-nnn Remove print_list from global scope #185

This method is defined on Object and so
is available globally. It appears to
be unused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant