Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and test Readonly "our" declarations. #29

Open
ronaldxs opened this issue May 1, 2017 · 1 comment
Open

Document and test Readonly "our" declarations. #29

ronaldxs opened this issue May 1, 2017 · 1 comment

Comments

@ronaldxs
Copy link
Contributor

ronaldxs commented May 1, 2017

"our" declarations seem to work with Readonly much like "my", with the expected differences. It would be helpful for the documentation to formally mention "our" declarations as a feature but there don't seem to be matching tests. I have started work on documentation and testing here: https://github.com/ronaldxs/readonly/tree/doc-test-our. It is not ready for a PR but hopefully shows some progress. The tests in t/general/our.t do not use eval like other Readonly test files and tests for limiting updates of "Readonly our" declared variables would need to be added.

@vsespb
Copy link

vsespb commented Sep 6, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants