headers data passed in from client app gets removed in function getAuthorizationHeader

[chongwahng]

Issue found at line 35 in destination.js of function "getAuthorizationHeader". This line removes the entire "headers" data passed in from client app and replaced it with auth token retrieved from destination.

function getAuthorizationHeader(_config, cfDestinationInfo) {
return new Promise((resolve, reject) => {
var error;
var config = Object.assign({}, _config);
//config.headers = {} ***** DEFECT

[chongwahng]

Shall I fork a new project and send in the changes with new pull request?

[gregorwolf]

Yes, please go ahead with a for and PR.

[chongwahng]

Just notice the change was already applied 4 months ago in your project file destination.js

"config.headers = {}" has been changed to "config.headers = config.headers || {};", however this change has not been officially released to npm registry yet.

[lniecap]

Is the fix planned to be officially released any time soon? There's still a version in the npm registry with the defect.

[gregorwolf]

Hi @raeijpe would you be able to take care of this issue and PR?