-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion] throws an error when it doesn't find the file/path #126
Comments
I think we can have a warning log in build. |
To be honest, I think it should fail once the application won't work as expected, but a warning would help a lot. 🙌 |
@sapphi-red, I was creating the PR when I saw this on my terminal: This validation is done here Guess it proves the warning is not enough. 😅 Anyway, let me know if makes sense to open the PR with an error msg; or I can keep the warning, but change the message like:
otherwise, we can close the issue. |
@sapphi-red what do you think? |
Hmmm, yeah, probably an error is better. So I think we need to cut a major version and also add an option to ignore the error. |
@sapphi-red perfect! Let me know what you think about this changes. |
This seriously hindered the way we use the plugin.
It feels like we'd need the silent option on each target. |
@vedranstipancic, which version were you using before it started, and which one now? |
[suggestion] throws an error when it doesn't find the file
I have been using the vite-plugin-static-copy for a while and recently I needed to move the file path it copies. So, I changed the copied file from
src/old-path
tosrc/new-path
, but I forgot to update the plugin configuration:Unfortunately, it does not throw any error, so I noticed it fails after manual validations. Does make sense to throw an error when the plugin doesn't find the file?
The text was updated successfully, but these errors were encountered: