-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 13 support - PhotoViewer unable to open image as permission changed #235
Comments
I've just made a new pull request to fix this issue #236 |
@AbidR-S2 We are still facing the issue and can't open the image. We can see Photos and videos permission under App Info and doesn't work even after enabling it manually. Here is our config XML :
Any solution? |
Are you installing the original plugin or my specific pull request with my code changes. You can see those code changes here https://github.com/sarriaroman/photoviewer/pull/236/files |
@banothurameshnaik and @AbidR-S2 , I've made the changes in the local code (inside node_modules - I know it's not the best solution and I'll change it afterwards) but it still doesn't work. It doesn't ask for permissions. I've done a cordova platform rm android && cordova platform add android@13 but still nothing... How can i best solve this? Any help appreciated and thanks for your hard work! Update: I've actually "solved" the issue by doing this: Remove current plugin: cordova plugin remove com-sarriaroman-photoviewer Add the plugin but using @AbidR-S2 PR: cordova plugin add https://github.com/sarriaroman/photoviewer.git#pull/236 |
For some reason dropping and re-adding the plugin fails with: I get the following error:
I am on a windows machine, command line. |
Strange, I've added it that way to 3 or 4 projects now and it worked, but I'm using MacOS |
@AbidR-S2 - is the pull reference above the same as your fork: It installs fine with
|
Well, for now I manually edited the PhotoViewer.java file with the @AbidR-S2 changes and it worked. Not certain why I couldn't do the plugin add with the pull/236 version, but hopefully someone merges all these fixes for the future. |
Well, it seems I was wrong in thinking this was solved. Although we are using pull/236 we tried to add a new release just now and Google Play is asking for a declaration for using the READ_MEDIA_IMAGES. Because it's not a frequent use i doubt they will allow our usage of this plugin. Isn't anyone else having this issue?? The deadline seemed to be today for removing the permission... We have a lot of work ahead of us to resolve this, i'm felling tired just thinking of it. |
My company app is for commercial site inspections so in my case the use is frequent and I will be submitting a declaration. You are able to ask for an extension easily enough and they granted it right away. Right now my deadline is May 28th with the extension. |
@AbidR-S2 Thanks for the reply. Where did you ask the extension? Was it in the declaration form they provide? |
I have already added all the necessary permissions to get I don't recall having seen this previously nor am I getting any Play Console notices about my app regarding these permissions for photoviewer. Please post link so I can look into this. Thank you. |
@rolinger I didnt have any errors also. This started appearing yesterday and it prevents submissions to production. It's related to: https://support.google.com/googleplay/android-developer/answer/14115180 |
Its in the Policy and Programs -> App Content section of the Play Console Clicking on learn more brings up: @jorgedferreira - I requested the extension a few months back, to be honest I can't remember where it was on the console or how you submit an extension. |
@AbidR-S2 I submited a description of why i use the permission. I'm gonna wait to see if the app is aproved. Either way, we will probably remove this component and use something else. |
Thanks guys. Turns out I answered all that previously...on Dec 21 2024 no less, but I completely forgot that I had done so. I must have had a few extra holiday eggnogs because I don't remember filling it out. Since then I have submitted 3 app updates with no issue, so I guess they have accepted my justification. |
@jorgedferreira - just fill it out and say your app needs it for moderate to frequent use. Its a lot easier than having to rewrite code. |
@rolinger Yeah, thanks, i did so. I'll be waiting for the reply... In my case, it is used almost daily. I have a few dozens of apps for supermarkets and the offers/promotions flyers they make are huge, so users need to be able to zoom. One thing i don't understand, all the images my users access are external to the device, they are read directly from an url... shouldn't need permissions for the phone's storage, but maybe there is a local copy made, dont know. Edit: well, obviously its needed because of other use cases, with local access to images, etc... |
when the app loads the external URL it then becomes embedded in the UI for the user. To access the now embedded image it requires the phone permissions. As well, |
Behavior changes: Apps targeting Android 13 or higher
https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions
Plugin doesn't support. Please update accordingly.
The text was updated successfully, but these errors were encountered: