You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a great package, but it was missing some features I needed and there were some low-hanging optimization fruit to pluck.
Rather than submitting a massive PR, I felt it was easier and faster to just clone and rewrite where needed. I give full credit to you for the original work, of course.
You might consider incorporating some of the changes made in the clone (https://github.com/linkdata/deadlock). Specifically
the use of runtime.CallersFrames to get correct line numbers, using build tags instead of Opts.Disable to avoid all overhead, leverage escape analysis for callers() to lower memory usage and maybe use of TryLock() for Go 1.18+.
The text was updated successfully, but these errors were encountered:
This is a great package, but it was missing some features I needed and there were some low-hanging optimization fruit to pluck.
Rather than submitting a massive PR, I felt it was easier and faster to just clone and rewrite where needed. I give full credit to you for the original work, of course.
You might consider incorporating some of the changes made in the clone (https://github.com/linkdata/deadlock). Specifically
the use of
runtime.CallersFrames
to get correct line numbers, using build tags instead ofOpts.Disable
to avoid all overhead, leverage escape analysis forcallers()
to lower memory usage and maybe use ofTryLock()
for Go 1.18+.The text was updated successfully, but these errors were encountered: