Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple threads and initial alignment #3

Open
smirarab opened this issue Oct 20, 2011 · 1 comment
Open

Multiple threads and initial alignment #3

smirarab opened this issue Oct 20, 2011 · 1 comment

Comments

@smirarab
Copy link
Member

It seems that in creating the initial alignments, we don't use multiple threads, even if available. Look at this code in the mainsate:

                for unaligned_seqs in multilocus_dataset:
                    job = sate_team.aligner.create_job(unaligned_seqs,
                                                       tmp_dir_par=init_aln_dir,
                                                       context_str="initalign",
                                                       delete_temps=delete_aln_temps)
                    _RunningJobs = job
                    jobq.put(job)
                    new_alignment = job.get_results()
                    _RunningJobs = None
                    new_alignment_list.append(new_alignment)

Shouldn't we break up this for loop to two loops (one for queuing, one for reading results) so that different markers could be aligned in parallel?

@mtholder
Copy link
Member

This has been fixed in commit 9727761
It did also require slight changes to the system for killing running jobs. Tested by hand, but we don't have a unit or integration test for this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants