Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiline fixes #13

Closed
kgevorkyan opened this issue Dec 19, 2022 · 0 comments · Fixed by #16
Closed

Support multiline fixes #13

kgevorkyan opened this issue Dec 19, 2022 · 0 comments · Fixed by #16
Assignees
@kgevorkyan
Labels
enhancement New feature or request

Comments

@kgevorkyan
Copy link
Member

kgevorkyan commented Dec 19, 2022 •
edited
Loading

For now we don't consider cases, when some fixes are multiline fixes, or represent the deletion of a multiline region

We need to do the following:

  • Group all fixes by file names Change order of fixes applying  #11
  • Sort fixes by start line
  • Check overlapping (max(A.startAt,B.startAt)<=min(A.endAt,B.endAt)) and apply only the first fix
  • Apply fixes for each file in reverse order, thus all indexes will be valid
@kgevorkyan kgevorkyan added the enhancement New feature or request label Dec 19, 2022
@kgevorkyan kgevorkyan self-assigned this Dec 19, 2022
This was referenced Dec 19, 2022
Merged
Merged
@kgevorkyan kgevorkyan linked a pull request Dec 22, 2022 that will close this issue
Support multiline fixes #16
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgevorkyan kgevorkyan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multiline fixes saveourtool/sarif-utils
1 participant
@kgevorkyan