Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use time-literals #33

Open
egli opened this issue Jun 16, 2021 · 0 comments
Open

Use time-literals #33

egli opened this issue Jun 16, 2021 · 0 comments
Labels

Comments

@egli
Copy link
Member

egli commented Jun 16, 2021

Currently the source-date of an item is parsed and serialized as a java.util.Date. When reading it from the db with edn/read-string it will be converted back to java.util.Date. The rest of the code base uses java.time and local-date.

It would be nice if we could move all to java.time. For that we need to enhance edn to store and read the types of java.time. There is a library which does that namely time-literals by Henry Widd.

One (major) downside of this is that we would have to migrate all existing edn strings in the database.

@egli egli added the prio:low label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant