Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal settings from the LSP-metals.sublime-settings #60

Open
ayoub-benali opened this issue Dec 4, 2021 · 3 comments
Open

Comments

@ayoub-benali
Copy link
Collaborator

ayoub-benali commented Dec 4, 2021

This file is editable by the user to tweak Metals behavior but it should not contain things like initializationOptions and other internal values

@rchl
Copy link
Collaborator

rchl commented Dec 4, 2021

Should or should not contain internal things?

Note that initializationOptions are typically not considered internal as user might want to tweak those in some cases. But not sure about this server specifically.

@ayoub-benali
Copy link
Collaborator Author

Typo sorry, I meant "should not".

I think mixing the server settings with settings internal to the package like "selector": "source.scala", and initializationOptions are confusing.
The user should be able to disable things like decorations, etc without having to fiddle with provider values.

@rchl
Copy link
Collaborator

rchl commented Dec 4, 2021

At least for some servers it makes sense to expose selector to allow the user to enable server on more file types. For example makes sense for LSP-eslint. Also initializationOptions in some cases control opinionated features that the user might want to toggle.

But you do as you wish. Maybe it makes sense for this server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants