Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification icon/badge #13

Open
nicolas2bert opened this issue Apr 18, 2019 · 3 comments
Open

Notification icon/badge #13

nicolas2bert opened this issue Apr 18, 2019 · 3 comments
Milestone

Comments

@nicolas2bert
Copy link
Contributor

nicolas2bert commented Apr 18, 2019

https://github.com/scality/pensieve-front/blob/master/src/react/ui-elements/NotificationIcon.jsx

Screen Shot 2019-04-18 at 2 35 04 PM

type Props = {
    content: string | number,
    variant: string, // "primary", "danger",...
    children: Node
}
<Badge content={4} variant="primary">
   <MailIcon />
 </Badge>

@carlito-scality carlito-scality added this to the MVP1 milestone Oct 31, 2019
@felipebrunetti94
Copy link
Contributor

felipebrunetti94 commented Dec 6, 2019

Hi @nicolas2bert , what is the problem, how can I contribute on this issue ?
It is just to create this component ?

@nicolas2bert
Copy link
Contributor Author

It seems components need to be created. Please, check with @carlito-scality.

@carlito-scality
Copy link
Contributor

carlito-scality commented Dec 11, 2019

It seems components need to be created. Please, check with @carlito-scality.

Yes, I think with the new design we are working in progress. This component should look like:
image
image

@felipebrunetti94 please wait until the new design is validated ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants