Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Mex files in version 1.13 #40

Open
rstdm opened this issue Mar 20, 2019 · 2 comments
Open

Missing Mex files in version 1.13 #40

rstdm opened this issue Mar 20, 2019 · 2 comments

Comments

@rstdm
Copy link

rstdm commented Mar 20, 2019

Hello,
I put some work in making the Python implementation work faster (see this pull request) and last week some colleagues of mine who are using Matlab asked me weather I could do something similar with the Matlab version.
I had a quick glance on the source code and found those few lines of code:

LIBVERSION = '1.13';
[…]
if ~have_mex
	 mex_url = ['https://github.com/sccn/xdf/releases/download/v',...
       		 LIBVERSION, '/', fname];
	websave(fullfile(this_path, fname), mex_url);

So obviously this code tries to download the correct binary from the release section of GitHub using it’s version number 1.13. But the latest release on that page is version 1.12 which causes the server to respond with a 404 error code.
Because the source code of load_xdf_innerloop.c hasn’t changed since version 1.12 it should be sufficient if you upload the same files as a new release for version 1.13.

Disclaimer: I’m no Matlab user and don’t have access to a Matlab installation. Therefore all I wrote above are theoretical assumptions.

@cll008
Copy link

cll008 commented Aug 8, 2019

I can confirm that this problem occurs on MATLAB exactly as you described.

@jiversen
Copy link

jiversen commented Sep 13, 2019

+1
But, you can compile for yourself
mex load_xdf_innerloop.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants