meson.build: enable LTO and -O3 for C schedulers #1155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htejun
approved these changes
Jan 4, 2025
|
Looks like linker fails when we use LTO. |
ptr1337
approved these changes
Jan 6, 2025
with static libbpf/bpftool. |
|
Yeah I am not sure what's going on, probably related to the missing library index (#1155 (comment)). Perhaps a more experienced user of Meson could help? (I don't know about meson that much) We need to run ranlib manually on |
|
Is I found a similar issue in Meson: mesonbuild/meson#8371 but nothing too useful where to try except changing a linker from |
|
In my case, I am fetching a specific commit of Line 142 in 382c879 And using Clang as the compiler for all targets. Could be related to mesonbuild/meson#4138 but that was apparently fixed. I tried to run ranlib manually but it didn't seem to work. Could you check on your end perhaps? |
Sure, why not. Could you please send me your exact build commands to reproduce the issue? I'll try to reproduce it in my Fedora-based env and report back the results. Thanks! |
|
I am using Nix (it automatically runs the build commands). I would say my configure flags are: And Nix build script is mostly following: https://github.com/sched-ext/scx?tab=readme-ov-file#static-linking-against-libbpf-preferred I am fetching libbpf and bpftool repos, which are built by meson. Log is here: https://pastebin.com/SCDe5e81 |
|
I quickly tried to reproduce your error but got other linking errors about undefined references: https://gist.github.com/zamazan4ik/3b013a6dc51dea1ede8a43e87fd440f0 |
|
Humm, errors related to cargo, which couldn't be caught from my side as I had disabled building rust schedulers with |
|
With |
Signed-off-by: John Titor <[email protected]>
it is indeed illegal to compile a C library with GCC and LTO, and then link to it in a rust program -- rust always uses LLVM's lto bytecode format, and doesn't support the GCC gimple format. I'm not really sure I understand this PR at all though as all it does is flip the defaults. Just like users are expected to configure with a suitable |
This was a follow up of #1011 as LTO was enabled by default for the Rust part. Anyways I got the point, enabling LTO for C scheds by default, should not be done due to people having different dev environment. But I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1011.
We can also set
b_lto_modetothin. Clang is especially good with thin-lto I hear. (https://mesonbuild.com/Builtin-options.html#base-options)CC #1010
CC @ptr1337 @htejun