Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RotationalSpring damping is ignored #358

Open
simonbw opened this issue Jun 29, 2020 · 0 comments
Open

RotationalSpring damping is ignored #358

simonbw opened this issue Jun 29, 2020 · 0 comments

Comments

@simonbw
Copy link

simonbw commented Jun 29, 2020

The damping property on RotationalSpring doesn't seem to have any effect. I believe that is due to this line where the damping torque is multiplied by 0.

RotationalSpring.prototype.applyForce = function(){
    // ... d = damping
    var torque = - k * (x - l) - d * u * 0;
    // ...
};

It looks like this was added intentionally at some point, but I'm not quite sure why, so I figured I'd create an issue to bring it up. Removing the * 0 seemed to make this function nicely for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant