Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to start or pull (broken tag?) #41

Open
JCGoran opened this issue Mar 10, 2021 · 0 comments · May be fixed by #43
Open

Unable to start or pull (broken tag?) #41

JCGoran opened this issue Mar 10, 2021 · 0 comments · May be fixed by #43

Comments

@JCGoran
Copy link
Contributor

JCGoran commented Mar 10, 2021

This is on the latest master (commit 2008cbb), with git 2.30.1.
Basically, running ./xfce-test start fails with:

Starting container: Unable to find image 'schuellerf/xfce-test:master' locally
docker: Error response from daemon: manifest for schuellerf/xfce-test:master not found: manifest unknown: manifest unknown.

Ditto for ./xfce-test pull (./xfce-start pull [TAG] works though).
Debugging the script with set -x reveals that it sets TAG=master using git, but there's no such Docker tag on Dockerhub. Since the git tags do not necessarily correspond to the Dockerhub tags, I think this causes the above behavior.

Proposed fix

Compare the output of the get_tagsfunction with whatever the user provided for TAG, or use latest if it's unset.

JCGoran added a commit to JCGoran/xfce-test that referenced this issue Mar 11, 2021
Instead of Git tags, it now parses Dockerhub tags instead.
Additionally, now it always uses 'latest' as the default tag.
@JCGoran JCGoran linked a pull request Mar 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant