Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wheels that are older than a threshold time limit #31

Closed
bsipocz opened this issue Aug 9, 2023 · 7 comments · Fixed by #33
Closed

Remove wheels that are older than a threshold time limit #31

bsipocz opened this issue Aug 9, 2023 · 7 comments · Fixed by #33
Labels
enhancement New feature or request

Comments

@bsipocz
Copy link
Member

bsipocz commented Aug 9, 2023

There are some 1 and 2 month old numpy wheels that haven't been identified for removal. They all have rc1 in their version number, so that may trip up the old wheel removing GHA.

https://anaconda.org/scientific-python-nightly-wheels/numpy/files?page=2

@bsipocz bsipocz added the bug Something isn't working label Aug 9, 2023
@matthewfeickert
Copy link
Member

matthewfeickert commented Aug 9, 2023

There are some 1 and 2 month old numpy wheels that haven't been identified for removal.

@seberg as your credentials were used to upload these can you remove them if you think that aren't useful currently? I'd prefer for project maintainers to do this.

They all have rc1 in their version number, so that may trip up the old wheel removing GHA.

No, the name information is not used beyond the project.

The reason those still exist is that they have been uploading numpy-2.0.0.dev0 wheels that overwrite the previous one and so they still only have 5 wheels on their project — the current limit.

env:
N_LATEST_UPLOADS: 5

anaconda show "${ANACONDA_USER}/${package_name}" &> >(grep '+') | \
awk '{print $2}' | \
head --lines "-${N_LATEST_UPLOADS}" > remove-package-versions.txt

So this isn't a bug in the current code, but a new feature request to also remove wheels past a certain time threshold. Seems like a good idea.

@matthewfeickert matthewfeickert added enhancement New feature or request and removed bug Something isn't working labels Aug 9, 2023
@matthewfeickert matthewfeickert changed the title BUG: old numpy wheels are not removed Remove wheels that are older than a threshold time limit Aug 9, 2023
@seberg
Copy link

seberg commented Aug 9, 2023

I have deleted all but the current ones.

EDIT: To be fair, I somewhat liked the exact version in the name with an auto-deleter of old ones, whatever the exact threshold. But numpy switched from a new version for each wheel to replacing the same version.

@matthewfeickert
Copy link
Member

Thanks @seberg!

@bsipocz
Copy link
Member Author

bsipocz commented Aug 9, 2023

Ahh, OK. This case, we should maybe have another, time-limit logic in the cleanup script, too. E.g. delete everything that is ~month old? At that point I think we can argue that it's not really a nightly build, but something broken.

@matthewfeickert
Copy link
Member

Yeah 1 month seems very reasonable. 👍

@bsipocz
Copy link
Member Author

bsipocz commented Aug 9, 2023

hah, I see that you already modified the issue here to reflect that. Thanks!

@matthewfeickert
Copy link
Member

Asked about how much datetime metadata we can get from Anaconda Cloud easily over on anaconda/anaconda-client#682.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants