-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wheels that are older than a threshold time limit #31
Comments
@seberg as your credentials were used to upload these can you remove them if you think that aren't useful currently? I'd prefer for project maintainers to do this.
No, the name information is not used beyond the project. The reason those still exist is that they have been uploading upload-nightly-action/.github/workflows/remove-wheels.yml Lines 18 to 19 in a2ba178
upload-nightly-action/.github/workflows/remove-wheels.yml Lines 68 to 70 in a2ba178
So this isn't a bug in the current code, but a new feature request to also remove wheels past a certain time threshold. Seems like a good idea. |
I have deleted all but the current ones. EDIT: To be fair, I somewhat liked the exact version in the name with an auto-deleter of old ones, whatever the exact threshold. But numpy switched from a new version for each wheel to replacing the same version. |
Thanks @seberg! |
Ahh, OK. This case, we should maybe have another, time-limit logic in the cleanup script, too. E.g. delete everything that is ~month old? At that point I think we can argue that it's not really a nightly build, but something broken. |
Yeah 1 month seems very reasonable. 👍 |
hah, I see that you already modified the issue here to reflect that. Thanks! |
Asked about how much datetime metadata we can get from Anaconda Cloud easily over on anaconda/anaconda-client#682. |
There are some 1 and 2 month old numpy wheels that haven't been identified for removal. They all have
rc1
in their version number, so that may trip up the old wheel removing GHA.https://anaconda.org/scientific-python-nightly-wheels/numpy/files?page=2
The text was updated successfully, but these errors were encountered: