Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a new inputs parameter named anaconda_nightly_upload_url #46

Closed
skoudoro opened this issue Nov 27, 2023 · 7 comments · Fixed by #47
Closed

Allow a new inputs parameter named anaconda_nightly_upload_url #46

skoudoro opened this issue Nov 27, 2023 · 7 comments · Fixed by #47

Comments

@skoudoro
Copy link
Contributor

Hi Scientific Python Team,

is it possible to add the optional input anaconda_nightly_upload_url.

Instead of creating a different fork, I would like to reuse this action for another anaconda repo (DIPY nightly wheels)

it would be great to have also the optional input label (manage anaconda label).

Let me know what you think, if it is possible to do that here or if I should fork and maintain an alternative version.

thank you for the feedback.

@stefanv
Copy link
Member

stefanv commented Nov 27, 2023

This sounds reasonable; and can be made optional so it won't impact current use. People may (will 😂) have opinions about the naming, but that can be discussed in the PR.

@matthewfeickert
Copy link
Member

matthewfeickert commented Nov 27, 2023

I had originally raised this idea in Issue #8, but it was decided to not go forward with it for the reasons discussed there.

I would be in favor of this, but before opening a PR let's ping @betatim and @bsipocz to see if they have different views now.

@stefanv
Copy link
Member

stefanv commented Nov 27, 2023

From that discussion, it wasn't clear there was an existing use-case. Also, it didn't look like @betatim or @bsipocz had strong reservations.

@bsipocz
Copy link
Member

bsipocz commented Nov 27, 2023

I would fully support this feature, the more packages using the action the better it is for the ecosystem. (My only reservations in the past was about the SP anaconda space and therefore to limit it to core libraries, or at least test it in practice and preferably work out policies before opening it up for domain packages)

@bsipocz
Copy link
Member

bsipocz commented Nov 27, 2023

People may (will 😂) have opinions about the naming, but that can be discussed in the PR.

fwiw, I like the suggested anaconda_nightly_upload_url, but as it's practically an extra pip index, maybe dropping anaconda from the name and somehow adding pip instead would make sense. But I really don't have strong opinions on it, any naming works for me.

@skoudoro
Copy link
Contributor Author

Thank all for the feedback.

It seems everyone is positif so I just created a PR(#47) to follow up on this.

@betatim
Copy link
Contributor

betatim commented Dec 1, 2023

Fine for me. Maybe we can use it to increase the number of people who are engaged with maintaining this action.

Though I think we should try and keep it reasonably focussed/tight in scope. Saying it out loud to keep those scope creep daemons under control ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants