Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulkrax5 CSV Parser #105

Open
5 tasks
ShanaLMoore opened this issue Aug 29, 2023 · 0 comments
Open
5 tasks

Bulkrax5 CSV Parser #105

ShanaLMoore opened this issue Aug 29, 2023 · 0 comments
Milestone
ActiveFedora migr...

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Aug 29, 2023 •
edited
Loading

This issue is to get Bulkrax 5.3.0 working with GBH's CSV Parser.

The CSV parser should continue using the child relationship job.

Fix failing specs related to CSVs. They were commented out in #93

  • rspec ./spec/models/bulkrax/csv_entry_spec.rb:167 # Bulkrax::CsvEntry exporting by Asset worktype creates the correct headers including valid PhysicalInstantation headers
  • rspec ./spec/models/bulkrax/csv_entry_spec.rb:151 # Bulkrax::CsvEntry exporting by Asset worktype creates the correct headers including valid Asset headers
  • rspec ./spec/models/bulkrax/csv_entry_spec.rb:183 # Bulkrax::CsvEntry exporting by Asset worktype creates the correct headers not including invalid model headers
  • rspec ./spec/models/bulkrax/csv_entry_spec.rb:131 # Bulkrax::CsvEntry exporting by Asset worktype with class method #build_export_metadata returns parent and children data as a single hash
  • rspec ./spec/models/bulkrax/csv_entry_spec.rb:97 # Bulkrax::CsvEntry builds entry with required metadata succeeds

sample docs: https://drive.google.com/drive/folders/1LrdWr0cZXQvouL5OpYeLgjRw6UBtgOR3
@ShanaLMoore ShanaLMoore changed the title Bulkrax CSV Parser Bulkrax5 CSV Parser Aug 29, 2023
@jillpe jillpe added this to the ActiveFedora migration milestone Aug 29, 2023
@jillpe jillpe added this to AMS / GBH Aug 29, 2023
@laritakr laritakr assigned laritakr and unassigned laritakr Aug 29, 2023
@ShanaLMoore ShanaLMoore mentioned this issue Aug 29, 2023
Closed
13 tasks
ShanaLMoore added a commit to WGBH-MLA/ams that referenced this issue Aug 29, 2023
@ShanaLMoore
🧹 skip failing csv entry specs
1111b61 
We are aware the the csv parser is currently failing. Because it's the last priority, we will skip these specs for now and resolve them when we work on the CSV parser.

ref: scientist-softserv#105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
AMS / GBH
Status: No status
Milestone
ActiveFedora migration
Development

No branches or pull requests
3 participants
@ShanaLMoore @laritakr @jillpe