Specs do not pass

[laritakr]

1416 examples, 73 failures, 38 pending - Failed examples: (as of 11/17/2023)
Some failures were due to IiifPrint PDF splitting, and were addressed by removing that feature in #189
Some appear to be flaky.

Feature specs:

• rspec ./spec/features/create_generic_work_spec.rb:39 # Create a GenericWork a logged in user with the :work_depositor role is expected to have visible link or button "Delete"
• rspec ./spec/features/feature_flag_spec.rb:46 # Admin can select feature flags as a repository admin has a setting for recently uploaded
• rspec ./spec/features/feature_flag_spec.rb:66 # Admin can select feature flags when all home tabs and share work features are turned off the page only shows the collections tab
• rspec ./spec/features/splash_spec.rb:15 # The splash page shows the page, displaying the Hyku version
• rspec ./spec/features/work_editor_role_spec.rb:80 # Work Editor role create permissions can create a work
• rspec ./spec/features/user_roles_spec.rb:97 # User Roles as a user reader can view the users index page
• rspec ./spec/features/user_roles_spec.rb:35 # User Roles as a user manager can visit the users index page
• rspec ./spec/features/create_paper_or_report_spec.rb:41 # Create a PaperOrReport a logged in user with the :work_depositor role is expected to have visible link or button "Delete"
• rspec './spec/features/oai_pmh_spec.rb[1:1:3:1]' # OAI PMH Support oai interface with works present with the oai_hyku prefix retrieves a list of records
• rspec './spec/features/oai_pmh_spec.rb[1:1:3:2]' # OAI PMH Support oai interface with works present with the oai_hyku prefix retrieves a single record
• rspec ./spec/features/oai_pmh_spec.rb:46 # OAI PMH Support when using the oai_hyku prefix includes non-DC fields
• rspec ./spec/features/create_etd_spec.rb:41 # Create a Etd a logged in user with the :work_depositor role is expected to have visible link or button "Delete"

Importer specs:

• rspec './spec/lib/importer/factory/image_factory_spec.rb[1:3:1]' # Importer::Factory::ImageFactory without a file creates a Work with supplied metadata
• rspec './spec/lib/importer/factory/image_factory_spec.rb[1:3:2]' # Importer::Factory::ImageFactory without a file updates a Work with supplied metadata
• rspec './spec/lib/importer/factory/image_factory_spec.rb[1:2:2:1]' # Importer::Factory::ImageFactory with a file when a work with the same id already exists updates metadata

Splash specs:

• rspec ./spec/views/splash/index.html.erb_spec.rb:16 # splash/index.html.erb Anonymous or non-Admin user with admin_only_tenant_creation=false displays a 'Get Started' button
• rspec ./spec/views/splash/index.html.erb_spec.rb:47 # splash/index.html.erb Anonymous user with admin_only_tenant_creation=true displays a 'Login to get started' button
• rspec ./spec/views/splash/index.html.erb_spec.rb:31 # splash/index.html.erb Admin user with admin_only_tenant_creation=true displays a 'Get Started' button
• rspec ./spec/views/splash/index.html.erb_spec.rb:62 # splash/index.html.erb Authenticated, non-Admin user with admin_only_tenant_creation=true displays a 'You are not authorized to create tenants' message

Misc Specs

• rspec ./spec/requests/admin_dashboard_spec.rb:22 # Admin Dashboard as an admin user I can hit every url corresponding to each link in the admin dashboard gets the url for activity summary

Misc Specs - Done

• rspec ./spec/forms/hyrax/image_form_spec.rb:6 # Hyrax::ImageForm.primary_terms includes the license field
• rspec './spec/forms/hyrax/generic_work_form_spec.rb[1:2:1]' # Hyrax::GenericWorkForm.primary_terms does not include the license field
• rspec './spec/forms/hyrax/generic_work_form_spec.rb[1:5:1]' # Hyrax::GenericWorkForm.secondary_terms includes the license field
• rspec './spec/forms/hyrax/generic_work_form_spec.rb[1:5:2]' # Hyrax::GenericWorkForm.secondary_terms includes the secondary_terms
• rspec ./spec/controllers/hyrax/images_controller_spec.rb:28 # Hyrax::ImagesController#presenter initializes a presenter
• rspec ./spec/controllers/hyrax/etds_controller_spec.rb:27 # Hyrax::EtdsController#presenter initializes a presenter

Ability specs - Done

- Addressed via #193

• rspec './spec/abilities/work_ability_spec.rb[1:1:2:10]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:11]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:5]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:9]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:4]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:6]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:3]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:2]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:7]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:13]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:12]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:2:8]' # Hyrax::Ability::WorkAbility when work editor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:12]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:4]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:11]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:10]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:7]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:9]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:2]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:6]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:3]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:5]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:13]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:1:3:8]' # Hyrax::Ability::WorkAbility when work editor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:9]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:2]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:7]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:6]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:4]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:8]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:11]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:13]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:5]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:12]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:3]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:3:10]' # Hyrax::Ability::WorkAbility when work depositor Etd permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:8]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:6]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:4]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:10]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:5]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:3]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:12]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:11]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:13]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:9]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:7]' # Hyrax::Ability::WorkAbility when work depositor Image permissions
• rspec './spec/abilities/work_ability_spec.rb[1:2:2:2]' # Hyrax::Ability::WorkAbility when work depositor Image permissions