Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations should have unless exists validations #242

Open
1 task
laritakr opened this issue May 17, 2023 · 0 comments
Open
1 task

Migrations should have unless exists validations #242

laritakr opened this issue May 17, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@laritakr
Copy link
Contributor

laritakr commented May 17, 2023

Story

To avoid migration errors in multi-tenant applications, migrations should be wrapped with:

unless table_exists?(:iiif_print_table_name)
.
.
.
end

There are no column changes or index changes, but if there were, those would be wrapped with unless column_exists? or unless index_exists?

See examples in British Library migrations

Acceptance Criteria

  • Modify all migrations to wrap with an existence check prior

Screenshots / Video

Screenshot 2023-05-17 at 11 49 57 AM

Testing Instructions and Sample Files

Notes

@laritakr laritakr added the bug Something isn't working label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant