-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁 IiifPrint Re Split PDF on command #294
Comments
1 task
jeremyf
added a commit
that referenced
this issue
Nov 27, 2023
For applications that have already installed IiifPrint, you'll need to manually add the following to your `config/routes.rb` file: ```ruby mount IiifPrint::Engine, at: '/' ``` Related to: - #292 - #294 Co-authored-by: LaRita Robinson <[email protected]>
jeremyf
added a commit
that referenced
this issue
Nov 27, 2023
For applications that have already installed IiifPrint, you'll need to manually add the following to your `config/routes.rb` file: ```ruby mount IiifPrint::Engine, at: '/' ``` Related to: - #292 - #294 Co-authored-by: LaRita Robinson <[email protected]>
jeremyf
added a commit
that referenced
this issue
Nov 28, 2023
For applications that have already installed IiifPrint, you'll need to manually add the following to your `config/routes.rb` file: ```ruby mount IiifPrint::Engine, at: '/' ``` Related to: - #292 - #294 Co-authored-by: LaRita Robinson <[email protected]>
jeremyf
added a commit
that referenced
this issue
Nov 28, 2023
This commit replaces raising exceptions when we can't derive the URL. Instead it opts to return nil and let the caller determine what to do. The primary result is that it's easier to have a rodeo configuration "miss" finding files in the pre-process location due to configuration issues. But alas, that's the nature of a rodeo. Related to: - #294
jeremyf
added a commit
to scientist-softserv/adventist-dl
that referenced
this issue
Nov 29, 2023
jeremyf
added a commit
to scientist-softserv/adventist-dl
that referenced
this issue
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
LaRita has a WIP PR that covers the backend work required for this feature 🎉 (this has not been tested yet).
We need to create a frontend button or interface, on a PDF fileset, that would trigger the backend behavior.
consider user permissions - the user should be able to edit.
Before starting, ask Jeremy for notes
Tasks
if @presenter.editor? ...
block)Hyrax::FileSetsController
with thesplit_pdf
action:id
parameter so that the decorator will properly behave.Considerations
(Jeremy here): I had thought about creating a separate controller, to avoid the decorator pattern. That separate controller would be
IiifPrint::PdfSplitsController
. The action would becreate
and follow the above guidance. Advantages would be keeping the controller space clear.I have several projects located on my machine; and it looks as though we have not overriden the file_sets behavior. See details:
Acceptance Criteria
The text was updated successfully, but these errors were encountered: