-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulkrax x Embargos/Leases #1010
Comments
Current bulkrax options from the parser: Is adding embargo/lease to the importer field part of this scope of work ?
Visibility via csv options: # The visibility of the record. Acceptable values are: "open", "embaro", "lease", "authenticated", "restricted". The default is "open"
#
# @return [String]
# @see https://github.com/samvera/hydra-head/blob/main/hydra-access-controls/app/models/concerns/hydra/access_controls/access_right.rb Hydra::AccessControls::AccessRight for details on the range of values.
# @see https://github.com/samvera/hyrax/blob/bd2bcffc33e183904be2c175367648815f25bc2b/app/services/hyrax/visibility_intention.rb Hyrax::VisibilityIntention for how we process the visibility.
def visibility
@visibility ||= self.parser_fields['visibility'] || 'open'
end |
TODO: test if it just works by adding to the CSV: |
In this commit, user are able to import embargo and lease rules via CSV headers. Issue: - scientist-softserv/palni-palci#1010
* 🎁 [i1010] - Add bulkrax support for Embargo and Lease Rules In this commit, user are able to import embargo and lease rules via CSV headers. Issue: - scientist-softserv/palni-palci#1010 * 🧹 [i1010] combine embargo and lease test fixtures Issue: - scientist-softserv/palni-palci#1010
Blocked merging it in for PITT until pals knapsacking is done. |
TODO:
|
Confirming that embargo/lease bulkrax works for active fedora and valkyrie |
New Issue since updating submodule: https://demo.palni-palci-staging.notch8.cloud/importers/7/entries/8?locale=en |
Blocked: There are failing specs (samvera/hyku#2260) and we need to update the submodule |
SoftServ QA: ✅ Screen.Recording.2024-08-14.at.12.59.24.PM.mov |
I tried submitting two imports: Both listed a "Total Works:" count as expected, but neither lists any Works, and neither presents any error messages. |
TODO: Look into why jobs don't appear to be running in staging |
For your uploads, I am seeing this error in the logs. I agree that not displaying the error is problematic (we can create a separate ticket for error handling), but could you fix the spreadsheets and try again?
|
Handing this back to cc @laritakr to rework the combined_files logic. STEPS TO REPRODUCE
The problem is combined_files is an empty array for this scenario. There are no remote files or thumbnail urls. However, FOR TESTING PURPOSES ONLY the attached sample file contains both columns (item and remote_files), to inspect combined_files and uploaded_files at the following debug location. |
TODO: set up pairing time with Rob to figure out blocker |
TODO: Update Bulkrax to released version and retest |
Summary
SOW
SoftServ will expand Bulkrax functionality by allowing the input of Embargo (and lease?) rules via CSV. Fields will include:
Visibility levels will correspond with current levels in Hyku Commons: Public, Institutional, Private. Date inputs will follow a single standard format; functionality will not be created to convert dates or handle multiple formats.
This work will be contributed back to Bulkrax and Hyku by SoftServ with acknowledgement to Hyku for Consortia and the University of Pittsburgh.
Acceptance Criteria
Screenshots or Video
Testing Instructions
Notes
Embargo format idea (per team meeting)
pitt-embargo.csv
Lease methods/options
so header proposal:
visibility_during_lease lease_expiration_date and visibility_after_lease
Edge case
Validations should be considered for the following scenarios:
The text was updated successfully, but these errors were encountered: