Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unit tests runtime #176

Open
nvaytet opened this issue Oct 4, 2024 · 4 comments
Open

Reduce unit tests runtime #176

nvaytet opened this issue Oct 4, 2024 · 4 comments

Comments

@nvaytet
Copy link
Member

nvaytet commented Oct 4, 2024

Running the unit tests is taking a long time (circa 10 minutes on CI).
We should try to reduce this.

This is most probably due to running workflows on full loki/sans2d data, which contains many pixels, leading to expensive memory allocations.
We should reduce the data to just a few pixels. We could for example extract a vertical line or slab of pixels, that would still have a discernable scattering pattern, but would be much less expensive.
Note that in the process, we would need a new detector bank shape specific for the tests.

@nvaytet nvaytet added the github_actions Pull requests that update GitHub Actions code label Oct 4, 2024
@nvaytet
Copy link
Member Author

nvaytet commented Oct 4, 2024

Note that the docs are also quite long to build, maybe something similar can be done there, although that may be more tricky if users download notebooks directly from the docs.

@SimonHeybrock
Copy link
Member

This will be easy to do for our own files, but not for the ISIS ones, I think?

@nvaytet
Copy link
Member Author

nvaytet commented Oct 4, 2024

I think we are loading hdf5 scipp format files that we created from the ISIS files? If so, we can do the same selecting a vertical strip of pixels? (maybe we want to keep a cross (+) of pixels so we can also compute Qx, Qy?

@SimonHeybrock
Copy link
Member

Maybe simply keeping every 2nd or 4th pixel would get us far enough?

@SimonHeybrock SimonHeybrock removed the github_actions Pull requests that update GitHub Actions code label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants