Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method of temp folder usage is potentially unsafe #12

Open
KnowZero opened this issue Nov 10, 2020 · 0 comments
Open

Method of temp folder usage is potentially unsafe #12

KnowZero opened this issue Nov 10, 2020 · 0 comments

Comments

@KnowZero
Copy link

There are 2 problems with the temporary images folder based on current implementation.

  1. If an images folder already exists in the current directory, that images folder will be deleted and you will lose all your images

Suggestion is to use a more custom naming scheme such as: ".animator-video-reference-temp"

  1. In the event of a crash, the old images are left in the undeleted folder, and running a different video can lead to more crashes (probably due to difference in image size)

Suggestion is to check for the temp image folder on run and removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant