Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works for version 5.0 #16

Open
Seraaron opened this issue Jun 13, 2022 · 1 comment
Open

Works for version 5.0 #16

Seraaron opened this issue Jun 13, 2022 · 1 comment

Comments

@Seraaron
Copy link

As far as I can tell, this script works for any Krita version above 4.2, and testing it out in Krita 5 seems to work just fine. However, in order to get it to work in Krita 5 I had to change the code in the checkKritaVersion() function to the following:

def checkKritaVersion(self):		
	# major version should be 4 or above	
	majorVersion = app.version().split(".")[0]
	# minor version should be 2 or above
	minorVersion = app.version().split(".")[1] 	

	if (int(majorVersion) < 4 ) & (int(minorVersion) < 2 ):
		self.kritaVersionOk = 0
		return

	self.kritaVersionOk = 1

Basically changing an OR to an AND for the minor version number.

Might I suggest this fix is included in future releases, unless someone finds some breaking issue in Krita 5 and above?

@KnowZero
Copy link

@Seraaron Just an fyi, 5.0 has animation video import built in.

File->Import video animation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants