Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic Engine is blurry again #548

Open
fsih opened this issue Jan 28, 2020 · 2 comments
Open

Sonic Engine is blurry again #548

fsih opened this issue Jan 28, 2020 · 2 comments

Comments

@fsih
Copy link
Contributor

fsih commented Jan 28, 2020

Expected Behavior

Sonic Engine text used to be crisp on reasonably performant devices

Actual Behavior

Sonic Engine's giant texture has regressed to being blurry again

Steps to Reproduce

See https://scratch.mit.edu/projects/74711180/

Operating System and Browser

Mac OSX Chrome

@adroitwhiz
Copy link
Contributor

It looks like this has been happening since #393.

Instead of backing off if a texture fails to render, the maximum texture size can be queried directly via gl.getParameter(gl.MAX_TEXTURE_SIZE).

There's still the question of what happens if you allocate too many large textures and run out of VRAM-- as far as I can tell, different browsers and possibly even different hardware may do different things.

@adroitwhiz
Copy link
Contributor

Try running this on your test hardware:
texture-allocation-test.zip

On my machine (Linux, NVIDIA GTX 780 Ti), both Firefox and Chromium happily eat up all my RAM creating textures beyond what can fit into VRAM at once.

I'd be interested to know if the same happens for the Chromebook mentioned in #393, or if it causes the WebGL context to be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants