Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should SvgRenderer's "fixup"/"transform" methods be moved out of the class? #91

Open
adroitwhiz opened this issue Apr 29, 2019 · 0 comments
Open

Should SvgRenderer's "fixup"/"transform" methods be moved out of the class? #91

adroitwhiz opened this issue Apr 29, 2019 · 0 comments

Comments

@adroitwhiz
Copy link
Contributor

Currently, there are several methods in the SvgRenderer class related to fixing and transforming various parts of SVGs (e.g. _transformText, _transformImages, _transformMeasurements). This makes the renderer code a tad bit messy. Should these methods be moved out of SvgRenderer?
@adroitwhiz adroitwhiz changed the title Should SvgRenderer's methods be moved out of the class? Should SvgRenderer's "fixup"/"transform" methods be moved out of the class? Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adroitwhiz