Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline is not always added to the default collection #3173

Open
yakanechi opened this issue Aug 21, 2024 · 0 comments
Open

Pipeline is not always added to the default collection #3173

yakanechi opened this issue Aug 21, 2024 · 0 comments

Comments

@yakanechi
Copy link
Contributor

What happened:
If pipelines are created at the same time, only one of them may be added.
The cause is probably the following locations.

// Check if the pipeline exists in the default collection
// to prevent the situation where a pipeline is deleted and then created right away with the same id
if (!defaultCollection.pipelineIds.includes(pipeline.id)) {
Object.assign(defaultCollection, {
pipelineIds: [...defaultCollection.pipelineIds, pipeline.id]
});
await defaultCollection.update();
}

When pipelines are created at the same time, only the pipeline ID of the UPDATE side that completes later is added because neither has been added to the default collection yet.

What you expected to happen:
All pipelines are added to the default collection even if they are created at the same time

How to reproduce it:
Create pipelines simultaneously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant