-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode coloration of command bar #161
Comments
hello sir can u please assign me this issue so i can get started .. and if i need any help can i message here? |
Sure thing, @indra057! Please let us know if you need any assistance and we'll do our best to help 😊 |
sir i didnt find the code exactly where do i need to fix the issue can u please guide me..or give me some more hints... |
@andrewtavis sir please reply |
Hi sorry, @indra057. A lot has come up recently between work and another program starting. @angrezichatterbox, would you be able to support here and direct @indra057 to where the change would need to happen for the command bar coloration? |
sorry @andrewtavis sir i am new to android development and i can't support that much as i didn't even understand the codebase and what is exactly happening i am just looking for simple issues that i can fix where should i change the commands exactly so that i can fix the issue of the coloration of the toolbar |
@angrezichatterbox will provide some guidance here today or tomorrow, @indra057 :) Again sorry that I can't look for you right now. |
@indra057, don’t worry if you’re new to Android development! I’ll give you a basic overview of how our codebase is structured, specifically regarding the keyboard functionality that you will be dealing with in this issue. Currently, we’re focusing on three main files:
Now, regarding the specific issue you’re working on, I recommend exploring the switchToToolbar function within the individual language services. Currently, this function changes the color of the top divider; you could also try adjusting the command bar color. In the individual keyboard IME, you’ll find how the colors are set for the translate and other buttons. If anything I’ve mentioned isn’t clear, please don’t hesitate to ask. I’m here to help! |
Terms
Description
This issue corrects a few issues with the command UI for the keyboards in dark mode:
X
to cancel the command selection or a command should also be white instead of black as is shown below2E2E2E
, the same color as the special keyboard keys in dark mode like delete, shift, etcContribution
Lots to do in this issue, and totally fine to do more than one PR for the various changes! 🎃 Happy to support as needed and review PRs as they come 😊
The text was updated successfully, but these errors were encountered: