Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all language references in code to ISO-2 codes #494

Open
2 tasks done
andrewtavis opened this issue Aug 24, 2024 · 1 comment
Open
2 tasks done

Switch all language references in code to ISO-2 codes #494

andrewtavis opened this issue Aug 24, 2024 · 1 comment
Assignees
Labels
feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

This issue is a simple one of renaming variables. As of now throughout the codebase we're naming variables based on the language and the ISO-2 code of the language, so like EnglishVarName and enVarName. We should rather use ISO-2 codes throughout the codebase so it's consistent.

As a part of this, we should also organize some of the new files within the repo, which can be done by maintainers in the PR that comes from this :)

Contribution

Happy to support with renaming and help move files around once the PR is up! 😊

@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 24, 2024
@andrewtavis
Copy link
Member Author

Note that we'll still have the Language names as directories names within the language keyboards directory, but the code references themselves should just be the two letter codes :)

@andrewtavis andrewtavis added the hacktoberfest Included as a part of Hacktoberfest label Sep 30, 2024
@henrikth93 henrikth93 self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants