From 29061f10b3f31564ff504876580a1359bd4705fe Mon Sep 17 00:00:00 2001
From: dreamATD <tianyi.liu.08@gmail.com>
Date: Thu, 9 Jan 2025 19:30:21 +0800
Subject: [PATCH] refine the protocol prover and verifier structs

---
 gkr_iop/examples/multi_layer_logup.rs |  5 +----
 gkr_iop/src/lib.rs                    | 14 +++++++++-----
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/gkr_iop/examples/multi_layer_logup.rs b/gkr_iop/examples/multi_layer_logup.rs
index 2f861cf93..5e003ea73 100644
--- a/gkr_iop/examples/multi_layer_logup.rs
+++ b/gkr_iop/examples/multi_layer_logup.rs
@@ -157,10 +157,7 @@ where
         res
     }
 
-    fn gkr_witness(&self, phase1: &[Vec<E::BaseField>], challenges: &[E]) -> GKRCircuitWitness<E>
-    where
-        E: ExtensionField,
-    {
+    fn gkr_witness(&self, phase1: &[Vec<E::BaseField>], challenges: &[E]) -> GKRCircuitWitness<E> {
         // Generate witnesses.
         let table = &phase1[self.committed_table];
         let count = &phase1[self.committed_count];
diff --git a/gkr_iop/src/lib.rs b/gkr_iop/src/lib.rs
index c5dcf203d..0e3ea1506 100644
--- a/gkr_iop/src/lib.rs
+++ b/gkr_iop/src/lib.rs
@@ -1,3 +1,5 @@
+use std::marker::PhantomData;
+
 use chip::Chip;
 use ff_ext::ExtensionField;
 use gkr::GKRCircuitWitness;
@@ -47,13 +49,15 @@ where
     fn phase1_witness(&self, phase1: Self::Trace) -> Vec<Vec<E::BaseField>>;
 
     /// GKR witness.
-    fn gkr_witness(&self, phase1: &[Vec<E::BaseField>], challenges: &[E]) -> GKRCircuitWitness<E>
-    where
-        E: ExtensionField;
+    fn gkr_witness(&self, phase1: &[Vec<E::BaseField>], challenges: &[E]) -> GKRCircuitWitness<E>;
 }
 
 // TODO: the following trait consists of `commit_phase1`, `commit_phase2`, `gkr_phase` and `opening_phase`.
-pub trait ProtocolProver<E: ExtensionField, Trans: Transcript<E>, PCS> {}
+pub struct ProtocolProver<E: ExtensionField, Trans: Transcript<E>, PCS>(
+    PhantomData<(E, Trans, PCS)>,
+);
 
 // TODO: the following trait consists of `commit_phase1`, `commit_phase2`, `gkr_phase` and `opening_phase`.
-pub trait ProtocolVerifier<E: ExtensionField, Trans: Transcript<E>, PCS> {}
+pub struct ProtocolVerifier<E: ExtensionField, Trans: Transcript<E>, PCS>(
+    PhantomData<(E, Trans, PCS)>,
+);