Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify tests where Identity() was needed as last transformation in a sequence #645

Open
1 task
LucaMarconato opened this issue Jul 25, 2024 · 1 comment

Comments

@LucaMarconato
Copy link
Member

In a test for sequence transformations I had to add some Identity() transformations due to a limitation of _get_current_output_axes(). See here:

# the function _get_current_output_axes() doesn't get called for the last transformation in a sequence,

  • verify that this is not needed anymore and drop the Identity() from the tests
@LucaMarconato LucaMarconato changed the title Identity() needed as last transformation in a sequence? simplify tests where Identity() was needed as last transformation in a sequence Jul 25, 2024
@LucaMarconato
Copy link
Member Author

I verified, the test is correct also when the last instances of Identity() are dropped, as expected. We need to make a small PR to remove them from the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant