Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow zero-len dataframes when parsing #662

Open
3 tasks
LucaMarconato opened this issue Aug 6, 2024 · 0 comments
Open
3 tasks

Disallow zero-len dataframes when parsing #662

LucaMarconato opened this issue Aug 6, 2024 · 0 comments
Labels
element: labels 🏷️ Regions as pixel masks element: points ⊙ Points in space

Comments

@LucaMarconato
Copy link
Member

LucaMarconato commented Aug 6, 2024

Parsing dataframes with zero length may lead to subtle bugs and has probably no use case. An example is to to_zarr.py script for the cosmx_io data in the sandbox. Parsing a zero-len dask-dataframe of points lead to a problem with unknown partitions.

We should

  • check for, and disallow, zero-len data in the parser.
  • add tests
  • also add a test to reproduce the bug with the cosmx data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
element: labels 🏷️ Regions as pixel masks element: points ⊙ Points in space
Projects
None yet
Development

No branches or pull requests

2 participants