Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session not reconnected after rolling upgrade #375

Open
Jadw1 opened this issue Sep 10, 2024 · 2 comments
Open

Session not reconnected after rolling upgrade #375

Jadw1 opened this issue Sep 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working triage

Comments

@Jadw1
Copy link

Jadw1 commented Sep 10, 2024

Observed in https://github.com/scylladb/scylla-enterprise/pull/4634#issuecomment-2333883650.

The test is running with force_gossip_topology_changes: true, so auth is not managed via raft and auth data is stored in system_auth keyspace with default replication factor 1. Test fails once per several runs.
It is doing rolling upgrade but sometimes the driver is not connected to some of the nodes after the rolling upgrade is finished (all nodes are up).

Reproducer:

@pytest.mark.asyncio
async def test_rolling_restart_with_auth(manager: ManagerClient):
    config = {
        'force_gossip_topology_changes': True,
    }
    servers = [await manager.server_add(config=config) for _ in range(3)]
    cql = manager.get_cql()
    hosts = await wait_for_cql_and_get_hosts(cql, servers, time.time() + 60)

    await manager.rolling_restart(servers)

I was running the reproducer in test/auth_cluster suite (enabled authentication) https://github.com/scylladb/scylladb/blob/master/test/auth_cluster/suite.yaml

During the upgrade, the driver cannot authenticate if replica which owns the part of token ring holding user data (system_auth has RF=1) is down. But it isn't reconnected after the node gets up.

pytest.log

@Jadw1
Copy link
Author

Jadw1 commented Sep 10, 2024

Cc @piodul @Lorak-mmk

@dkropachev
Copy link
Collaborator

@scylladb/drivers-team

@dkropachev dkropachev added bug Something isn't working triage labels Sep 10, 2024
@kostja kostja self-assigned this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

3 participants