Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long term: deal with positioners with unexpected behaviours #187

Open
albireox opened this issue Jun 10, 2022 · 0 comments
Open

Long term: deal with positioners with unexpected behaviours #187

albireox opened this issue Jun 10, 2022 · 0 comments
Assignees

Comments

@albireox
Copy link
Member

Right now we have three main robot categories:

  • Normal robots that behave and reply normally.
  • Disabled robots that may not move correctly but otherwise reply properly and know where they are.
  • Offline robots that are not connected to a daisy chain but physically in the wok.

A fourth category of robots that we don't currently manage, mostly because we have been able to avoid them, are positioners that are connected and reply but with invalid or unexpected messages. For example, a robot that feels its sync line always high will fail to initialise because SET_SPEED fails with an ALREAD_IN_MOTION error. So far we have dealt with these cases by disconnecting them so that they become offline robots, but that may not be always possible.

Ideally we would want to mark these robots as offline but without actually disconnecting them, and that should work for most commands but not for broadcasts right now. If we mark these robots as offline the code will not expect a reply from them, but they will reply to most broadcast commands leading to replies arriving after the command is already done.

Solutions are to stop using broadcasts altogether (except for START_TRAJECTORIES) or add a new category of offline_but_alive that we count for broadcasts but otherwise treat as offline.

@albireox albireox self-assigned this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant