New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BinaryEncoder #539

Open

amontanez24 opened this issue Aug 17, 2022 · 0 comments

Labels

feature request

Contributor

amontanez24 commented Aug 17, 2022

Problem Description

The BinaryEncoder is not as effective as the LabelEncoder so it should be replaced with it and removed down the line.

Expected behavior

Change the default transformer for boolean columns to the LabelEncoder
Raise the following deprecation warning whenever users try to use the BinaryEncoder
- This should be in the following methods:
  - update_transformers
  - update_transformers_by_sdtype
  - set_config
- Use this message
  - Deprecation Warning: BinaryEncoder will no longer be supported in future versions of RDT. Please use the LabelEncoder instead.

Additional context

The text was updated successfully, but these errors were encountered:

amontanez24 added the feature request label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment