Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If first 5 values of columns are the same, the seed is the same. Should it be different? #916

Open
npatki opened this issue Nov 25, 2024 · 0 comments
Labels
feature request Request for a new feature

Comments

@npatki
Copy link
Contributor

npatki commented Nov 25, 2024

Problem Description

RDT is supposed to be setting the random seed based on the first 5 values in the column. For a lot of cases, this is sufficiently allows users to:
(a) transform/reverse transform in a reproducible way while also
(b) creating different data for each different column

However, this would break down if you have 2 different columns and the first 5 values of those columns are exactly the same. In such a case, the random seed for those columns would be exactly the same, so whatever randomness they have will be in-sync.

This is a general issue that we can use to track the problem. If it ends up affecting a lot of users, we may want to consider finding a different way to set the seed.

Additional context

This issue assumes that #906 has already been fixed. (#906 identifies an bug where the first five column names are being used rather than the first 5 data values.)

@npatki npatki added the feature request Request for a new feature label Nov 25, 2024
@fealho fealho self-assigned this Nov 26, 2024
@fealho fealho added this to the 1.13.2 milestone Nov 26, 2024
@fealho fealho removed their assignment Nov 26, 2024
@fealho fealho removed this from the 1.13.2 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants