Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 (excluding pomegranate) #645

Open
amontanez24 opened this issue Oct 25, 2024 · 1 comment
Open

Support Python 3.13 (excluding pomegranate) #645

amontanez24 opened this issue Oct 25, 2024 · 1 comment
Labels
feature request Request for a new feature maintenance Tasks related to infrastructure & dependencies

Comments

@amontanez24
Copy link
Contributor

Problem Description

Python 3.13 was released Oct 7, 2024. We should begin to add support for it.

Expected behavior

  • Support python 3.13
@amontanez24 amontanez24 added feature request Request for a new feature new Label applied to new issues maintenance Tasks related to infrastructure & dependencies and removed new Label applied to new issues labels Oct 25, 2024
@npatki
Copy link
Contributor

npatki commented Feb 7, 2025

After discussing with @amontanez24 and @rwedge: We should be able to upgrade the default SDMetrics library to 3.13 without an issue.

The only problem is the pomegranate dependency. Although they have put out a version that is compatible with Python 3.13, it has a few problems:

  • (a) There are some blocking API changes that we'd need to update, but more importantly
  • (b) There is an problem with the way that their license is showing up that would make pomegranate a blocker for some of our enterprise users.

Good news is that pomegranate is an optional dependency that is only used for the BNLikelihood and BNLogLikelihood metrics. So overall, this is a non-blocker for the rest of SDMetrics.

Expected Behavior

  • If I'm on Python 3.13, I should be able to install SDMetrics (default version) without any issues (pip install sdmetrics)
  • If I require pomegranate, then I need to be on Python 3.12 or lower (pip install sdmetrics[pomegranate])

I will update the title to clarify.

@npatki npatki changed the title Support Python 3.13 Support Python 3.13 (excluding pomegranate) Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Development

No branches or pull requests

2 participants