Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Constraints access to the metadata #1721

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Conversation

fealho
Copy link
Member

@fealho fealho commented Dec 18, 2023

CU-86aytb6w0, Resolve #1692.

This PR gives access to the metadata to each constraint instance.

@sdv-team
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d987178) 97.08% compared to head (b127fe9) 97.07%.

❗ Current head b127fe9 differs from pull request most recent head f25037b. Consider uploading reports for the commit f25037b to get more accurate results

Files Patch % Lines
sdv/constraints/base.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1721      +/-   ##
==========================================
- Coverage   97.08%   97.07%   -0.02%     
==========================================
  Files          48       48              
  Lines        4499     4506       +7     
==========================================
+ Hits         4368     4374       +6     
- Misses        131      132       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review January 3, 2024 13:26
@fealho fealho requested a review from a team as a code owner January 3, 2024 13:26
@fealho fealho requested a review from amontanez24 January 3, 2024 13:26
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fealho fealho merged commit 4fec815 into main Jan 11, 2024
37 checks passed
@fealho fealho deleted the issue-1692-inequality-error branch January 11, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidDataError for Inequality constraint (even though data is valid)
5 participants