Add primary key auto-detection for semantic sdtypes #1731
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
- Coverage 97.13% 97.11% -0.02%
==========================================
Files 48 48
Lines 4507 4512 +5
==========================================
+ Hits 4378 4382 +4
- Misses 129 130 +1 ☔ View full report in Codecov by Sentry. |
fealho
requested review from
rwedge and
frances-h
and removed request for
a team
| # When no primary key column was set, choose the first pii field | ||
| if self.primary_key is None and first_pii_field: | ||
| self.primary_key = first_pii_field |
There was a problem hiding this comment.
Just to clarify, is the logic we want here to set the primary key to the first ID or PII column we find? Or is it to fall back on PII columns only if we don't find an ID column in the table?
There was a problem hiding this comment.
The issue doesn't specify, so I implemented the second approach. I could change this if we have evidence that PII columns are just as likely as ID ones to be selected as primary keys (in real world datasets).
CU-86ayxgv0h, Resolve #1724