-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infer_sdtypes
and infer_keys
parameters to detect_from_dataframes
method
#2363
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 59 59
Lines 6130 6144 +14
=======================================
+ Hits 6043 6057 +14
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4b6dba4
to
1209687
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just had one comment
CU-86b3f92p5, Resolve #2341.
A few notes about the PR:
infer_sdtypes=False
means primary and foreign keys will not be detected. Primary keys can't be detected because all sdtypes are unknown and foreign keys are not detected because there are no primary keys.infer_sdtypes=False
will set all columns topii=True
. This is the default behavior for columns withunknown
sdtype.Metadata
class methods, not toMultiTableMetadata
orSingleTableMetadata
.