Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of Github actions for CI? #2

Open
wweijtje opened this issue Jun 27, 2023 · 1 comment
Open

Inclusion of Github actions for CI? #2

wweijtje opened this issue Jun 27, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@wweijtje
Copy link
Contributor

One of the most efficient ways to improve code quality for packages is to include a pipeline that is triggered on e.g. a commit on master or when a pull request is launched. These tools force a certain level of quality and e.g. prevent to commit a version that fails the unittests.

Typical steps are:

  • run unittest
  • linting the code (e.g. blacken)
  • check compliance with e.g. PEP8
  • update the version number (e.g. major/minor release)
  • build documentation
  • publish on pypi (e.g. only when a merge on the main branch is done)

At least a part of these actions can be readily achieved through github actions: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python

Some examples :

Tradeoff here is to balance complexity (too many elements increases the risk for the pipeline to fail and thus frustration) against the gain (higher Quality).

@jankoslavic jankoslavic added the help wanted Extra attention is needed label Jun 28, 2023
@jankoslavic
Copy link
Contributor

This is great! Thank you @wweijtje !
This is a relatively easy task, I have marked it as "help wanted" to give the community the opportunity to join the effort. I guess somebody with prior experience could set-up this.

If it is not handled in a reasonable time, we I will take care of this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants