-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider opening up min_impurity_decrease
in survival tree for early stoppping?
#144
Comments
I agree that it would be nice.
The reason why it is not included is that sklearn's Cython
implementation expects that a split criterion computes an error/impurity
per node from which some other sklearn class computes the improvement.
For a survival tree, I would need the log-rank statistic as impurity,
which is computed on the split level and not the node level. So far I
couldn't find an easy way to make this happen using sklearn's Cython API.
|
But the logrank criterion doesn't really use the concept of "node impurity" and that's why they are set to be all inf and not used in the algo, right? |
Currently, If you have code already, it would be great if you could create a PR with your changes. |
Hello there,
Is it correct understanding that
proxy_impurity_improvement
here is in fact the log-rank z stats? In which case is it possible to open upmin_impurity_decrease
as a param like in sklearn as early stopping criteria instead of forcing it to be 0?scikit-survival/sksurv/tree/tree.py
Line 227 in 3f19c9f
Thanks,
Agnes
The text was updated successfully, but these errors were encountered: