Signup Wizard Plugin - Wrong campus being assigned to connection request

[stanalyst]

After upgrading to v1.4.1 of this plug-in - we discovered that in certain scenarios the wrong campus was being used for the connection request created. Instead of using the campus that was selected in the wizard and passed to the signup page via the page parameter - the current person's campus was used instead. 90% of the time this causes no issue - since most folks signup to serve on their own campus. But when a person tries to signup on a different campus - the connection request ends up being their own campus - not the one they selected.

We tracked the issue to the file VolunteerSignupFormConnetions.ascx.cs. There is logic in it which gets the Campus from the page parameters ... but unfortunately - there is also logic to default the selected campus to the current person's campus.

From looking at the history of this file - prior to the commit on Nov 17, 2020 - the order of these 2 pieces of logic was page parameter then current person ... so effectively if a person was logged in - their campus always overrode what they had selected via the signup wizard.

The commit on Nov 17, 2020 appears to address the specific issue we're experiencing. The change in that commit seems to simply be that the page parameter logic was moved after the current person logic.

And it appears the version of this file that is included in the v1.4.1 package doesn't include the fixes from the Nov 17, 2020 commit.

The only reason I can guess why this all worked for us prior to updating to v.1.4.1 - we must have update the file ourselves (maybe in Nov 2021 based on file timestamps in backups).